-
Notifications
You must be signed in to change notification settings - Fork 455
ci-entrypoint.sh: Incrementally scale large clusters #5779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This offers an alternative approach to #5776. |
/test pull-cluster-api-provider-azure-ci-entrypoint |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5779 +/- ##
==========================================
- Coverage 52.82% 52.81% -0.02%
==========================================
Files 279 279
Lines 29629 29602 -27
==========================================
- Hits 15652 15634 -18
+ Misses 13160 13154 -6
+ Partials 817 814 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/test pull-cluster-api-provider-azure-ci-entrypoint |
/test pull-cluster-api-provider-azure-ci-entrypoint |
/test pull-cluster-api-provider-azure-ci-entrypoint |
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds |
1 similar comment
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds |
/test ? |
@nojnhuh: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds |
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds |
d37d921
to
aa229a2
Compare
Co-Authored-By: Jack Francis <[email protected]>
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds |
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/close |
@nojnhuh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a new level of looping while ci-entrypoint.sh waits for nodes to come online that will incrementally scale the cluster to reach the desired number of nodes. This should help large clusters come up more reliably than when all the machines are created at once.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: